[NFC][lldb-dap] Add missing header guard for DAPError and ProgressEvent. #145915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete the copy, move construction and assignment.
|
@llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changesdelete the copy, move constructor and assignment for ProgressEventReporter. Full diff: https://github.com/llvm/llvm-project/pull/145915.diff 2 Files Affected:
diff --git a/lldb/tools/lldb-dap/DAPError.h b/lldb/tools/lldb-dap/DAPError.h
index e18614fe71935..e3ad10806a343 100644
--- a/lldb/tools/lldb-dap/DAPError.h
+++ b/lldb/tools/lldb-dap/DAPError.h
@@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//
+#ifndef LLDB_TOOLS_LLDB_DAP_DAPERROR_H
+#define LLDB_TOOLS_LLDB_DAP_DAPERROR_H
+
#include "llvm/Support/Error.h"
#include <optional>
#include <string>
@@ -50,3 +53,5 @@ class NotStoppedError : public llvm::ErrorInfo<NotStoppedError> {
};
} // namespace lldb_dap
+
+#endif // LLDB_TOOLS_LLDB_DAP_DAPERROR_H
\ No newline at end of file
diff --git a/lldb/tools/lldb-dap/ProgressEvent.h b/lldb/tools/lldb-dap/ProgressEvent.h
index d1b9b9dd887cd..55c7bd73f324e 100644
--- a/lldb/tools/lldb-dap/ProgressEvent.h
+++ b/lldb/tools/lldb-dap/ProgressEvent.h
@@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//
+#ifndef LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H
+#define LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H
+
#include <atomic>
#include <chrono>
#include <mutex>
@@ -13,8 +16,6 @@
#include <queue>
#include <thread>
-#include "DAPForward.h"
-
#include "llvm/Support/JSON.h"
namespace lldb_dap {
@@ -129,8 +130,12 @@ class ProgressEventReporter {
public:
/// \param[in] report_callback
/// Function to invoke to report the event to the IDE.
- ProgressEventReporter(ProgressEventReportCallback report_callback);
+ explicit ProgressEventReporter(ProgressEventReportCallback report_callback);
+ ProgressEventReporter(const ProgressEventReporter &) = delete;
+ ProgressEventReporter(ProgressEventReporter &&) = delete;
+ ProgressEventReporter &operator=(const ProgressEventReporter &) = delete;
+ ProgressEventReporter &operator=(ProgressEventReporter &&) = delete;
~ProgressEventReporter();
/// Add a new event to the internal queue and report the event if
@@ -156,3 +161,5 @@ class ProgressEventReporter {
};
} // namespace lldb_dap
+
+#endif // LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H
\ No newline at end of file
|
JDevlieghere
approved these changes
Jun 26, 2025
lldb/tools/lldb-dap/ProgressEvent.h
Outdated
| @@ -156,3 +161,5 @@ class ProgressEventReporter { | |||
| }; | |||
|
|
|||
| } // namespace lldb_dap | |||
|
|
|||
| #endif // LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H | |||
anthonyhatran
pushed a commit
to anthonyhatran/llvm-project
that referenced
this pull request
Jun 26, 2025
…nt. (llvm#145915) Delete the copy, move constructor and assignment for ProgressEventReporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete the copy, move constructor and assignment for ProgressEventReporter.