Add duplicate identifier error for using declarations shadowed in for-of loops #61925
+1,682
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
using
declaration in a for-of loop head has the same name as a declaration in the loop body, the transformed output generates conflicting variable declarations that can cause runtime errors. This PR adds a compile-time error to catch this issue early.Problem:
When compiled to ES5, this generates:
Solution:
Added a new check in
checkForOfStatement
that detects when:Using
flag (covers bothusing
andawait using
)< LanguageFeatureMinimumTarget.UsingAndAwaitUsing
)When these conditions are met, TypeScript now reports:
Key Features:
using
andawait using
declarationsconst
,let
,var
)Testing:
Added comprehensive test cases covering various scenarios and verified that existing functionality remains unaffected.
Fixes #61714.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.