Improved the performance of generated-files.Dockerfile by skipping pa… #5948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckaging of unused files Signed-off-by: Gili Tzabari <cowwoc2020@gmail.com>
cowwoc
force-pushed
the
trim-generated-files
branch
from
84075fd to
69a2929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ckaging of unused files
Following up on #5924, I noticed that exporting files from the protobuf stage is extremely slow and of the 5800+ files, only 5 are actually needed to build language bindings. This reduces the build time by 2 minutes on my end.
@jsternberg As far as I can tell, the
googleapisstage contains the majority of the unused files and it isn't actually used by anyone. Can you please confirm this is the case?