-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Improve test clarity and execution time. #1743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JAVA-5898
); | ||
} | ||
|
||
@ParameterizedTest | ||
private static BufferProvider createBufferProvider(final String bufferName, final BufferProvider bufferProvider) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about my point. Is it true that bufferDescription is more appropriate naming? Saw it is used to overwrite toString.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, changed to bufferDescription
.
@@ -660,7 +691,7 @@ void shouldSkipCStringWhenMultipleNullTerminationPresent(final byte[] cStringByt | |||
} | |||
} | |||
|
|||
@ParameterizedTest | |||
@ParameterizedTest(name = "should read skip CString when multiple null termination present within buffer. BufferProvider={0}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "multiple null terminations" preferable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it has to be plural. And now I think the correct term here is “terminators,” not “termination,” so I changed it to “terminators.”
@DisplayName
is not reflected in Evergreen test reports because Gradle’s XUnit XML output doesn’t include it for parameterized tests. Only thename
attribute of@ParameterizedTest
is preserved and shown in Evergreen.JAVA-5898