-
-
Notifications
You must be signed in to change notification settings - Fork 35.8k
RenderObject: Check attributes version of the geometry #31227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
||
vaoGPU = this.vaoCache[ vaoKey ]; | ||
|
||
if ( vaoGPU === undefined ) { | ||
|
||
let staticVao; | ||
|
||
( { vaoGPU, staticVao } = this._createVao( renderObject.getAttributes() ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RenaudRohlinger @aardgoose I made some changes to staticVao
, making it fixed but relating it to the attributes but keeping it shared by vaoKey
, in case you have any additional observations about this change in your tests.
Fixes #30168
Description
Check attributes version of the geometry for dynamic replacement. Like: