fix: only trigger rebuild when relevant parts of the package manifest changed #3966
Conversation
… has been changed
| let serialized = serde_json::to_vec(&project_model) | ||
| .map_err(GlobHashError::ProjectModelSerialization)?; |
There was a problem hiding this comment.
This is pretty weird, but I couldn't find a way to just pass an object implementing Hash to Sha256.
And just hashing with the default hasher also seems like a bad idea, since it's not stable across Rust releases.
I'd appreciate better ideas.
There was a problem hiding this comment.
We could use xxh3 hash which implements Hasher and seems stable enough and is much faster.
Hofer-Julian
force-pushed
the
feature/pix-396-only-trigger-rebuild-when-relevant-parts-of-the-package
branch
from
52ad017 to
e15cb56
Compare
| @@ -20,18 +22,28 @@ pub struct GlobHashKey { | |||
| root: PathBuf, | |||
| /// The glob patterns. | |||
| globs: BTreeSet<String>, | |||
| /// The project model. | |||
| project_model: Option<ProjectModelV1>, | |||
There was a problem hiding this comment.
It seems like quite a waste to have an owned type here. Perhaps we can use a generic lifetime?
There was a problem hiding this comment.
Im not entirely happy that we have this type in here. Previously this type was very standalone and now we tie it to pixi_build_types.
Maybe we should extract computing the actual hash (including the project model) somewhere else.
If we refactor computing the hash by using the Hash trait, we can make it more extensible.
Fixes #3123
CI will only be green after prefix-dev/pixi-build-testsuite#8 is merged and vice versa.
I suggest to first merge the testsuite PR and restart CI for this one and merge it if CI is green.