Use BCL CipherMode enum for AesCipher class #1564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-xu
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
… class; Create a dedicated AesCtrCipher class just like AesGcmCipher class.
scott-xu
force-pushed
the
bcl-ciphermode
branch
from
166cd93 to
e02f749
Compare
|
Is there a benefit to this? |
|
FYI: some previous discussion: #865 (comment) |
|
The main purpose is to use BCL as possible as it can. |
|
Thanks, I remember the previous discussion, but I don't think it is worth changing the API right now. Maybe at a later time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a dedicated AesCtrCipher class just like AesGcmCipher class.
Relate to #1560