Replace hardcoded config fallback version with dynamic constant #381
Conversation
Previously, when loading the config file, the fallback version `”0.3.0"` was hardcoded to handle unversioned configs from earlier releases. This commit replaces the hardcoded value with the centralized `version` constant, ensuring consistency across the codebase and reducing the risk of version mismatches in the future.
belkhadir
requested review from
shahmishal,
cmcgee1024,
justice-adams-apple and
etcwilde
as code owners
|
Thank you for this contribution. The code is working as designed at the time, which is that the version would have to be "0.3.0" (or earlier) if there's no version field in the config.json. This sets the version so that it can be compared further down the line for any migrations of the swiftly installation. Since swiftly does not support upgrading from "0.3.0" and earlier the change here might be to make the version field mandatory, and remove this set if it's not set code. |
This commit aligns with the decision to drop support for configurations without a version field (pre-0.3.0). The `version` property in `Config` is now non-optional and must be explicitly set at creation. - Removed the fallback assignment to "0.3.0" - Updated all code to require and use non-optional `version` - Adjusted the config initializer to take `version` as a parameter - Simplified conditional checks and eliminated `.version?` This ensures that swiftly no longer silently accepts or upgrades legacy configurations without an explicit version.
|
Thanks for the clarification; that makes perfect sense. I've updated the code to make the |
|
@belkhadir there's a few compile errors in the tests, and some code reformatting needed for this. To reformat the code you can use |
|
@cmcgee1024 Thanks for the feedback! I've fixed the test compilation errors and applied formatting. I also noticed a two warning ( |
@belkhadir let's keep this PR focused on this one area. Additional PR's are welcome. Thanks. |
Previously, when loading the config file, the fallback version
"0.3.0"was hardcoded to handle unversioned configs from earlier releases.This MR replaces the hardcoded value with the centralized
SwiftlyCore.versionconstant, ensuring consistency across the codebase and reducing the risk of version mismatches in the future.