Add const-tensor checks #3141
Open
Add const-tensor checks #3141
+59
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tensorflow/micro Add consistent const-tensor checks and error messages across these kernels: TRANSPOSE STRIDED_SLICE FILL BROADCAST_TO EXPAND_DIMS Modify associated kernel unit tests. bug=fixes tensorflow#3140
| if (dims_data != nullptr) { | ||
| // dims must be a const tensor | ||
| tensors[0].allocation_type = kTfLiteMmapRo; | ||
| } |
There was a problem hiding this comment.
Better to have this condition after all the tensor creations are done?
| output_data); | ||
| tflite::micro::KernelRunner runner = | ||
| CreateFillTestRunner(dims_shape, dims_data, value_shape, value_data, | ||
| output_shape, output_data); |
There was a problem hiding this comment.
I just want to understand few things here.
- Is this test was successful previously?
- Do we want to make this test fail in the prepare stage?
- Why can't we use TestFill() API here aswell?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tensorflow/micro
Add consistent const-tensor checks and error messages across these kernels: TRANSPOSE
STRIDED_SLICE
FILL
BROADCAST_TO
EXPAND_DIMS
Modify associated kernel unit tests.
bug=fixes #3140