feat: add total duration section #3898
Conversation
Bundle ReportChanges will increase total bundle size by 1.71kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Bundle ReportChanges will increase total bundle size by 1.71kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3898 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 828 828
Lines 15065 15083 +18
Branches 4310 4311 +1
=======================================
+ Hits 14861 14879 +18
Misses 196 196
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3898 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 828 828
Lines 15065 15083 +18
Branches 4302 4311 +9
=======================================
+ Hits 14861 14879 +18
Misses 196 196
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3898 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 828 828
Lines 15065 15083 +18
Branches 4302 4319 +17
=======================================
+ Hits 14861 14879 +18
Misses 196 196
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3898 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 828 828
Lines 15065 15083 +18
Branches 4310 4319 +9
=======================================
+ Hits 14861 14879 +18
Misses 196 196
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
✅ Sentry found no issues in your recent changes ✅ |
| } | ||
| slowestTestsDuration={aggregates?.slowestTestsDuration} | ||
| <div | ||
| className={cn( |
joseph-sentry
changed the title
joseph-sentry
force-pushed
the
joseph/total-duration
branch
from
3b18039 to
2a35eea
Compare
|
@joseph-sentry The without flake aggregates screenshot still has the flake rate column on there ;P Also any chance we can center those fields when theres only 3? Looks kinda odd shifted like that |
|
I just noticed all the wasted space at the right of the table. Can we right-justify everything but the test name column? |
|
I'm going to end up leaving the slowest tests header in and not make any changes to the header section and just add the time spent column in this change |
joseph-sentry
dismissed stale reviews from ajay-sentry and spalmurray
rewrote a bunch of the PR
I noticed that any time I would refresh the page or change the ordering of the table, which would cause useInfiniteTestResults to run, the flake rate column would disappear for just a second until we got the response back and then the flake rate column would come back. This fixes this by preventing the value used in rendering from being updated until the request is done, preventing the flickering i saw.
joseph-sentry
force-pushed
the
joseph/total-duration
branch
from
d325b29 to
c4bf955
Compare
| const isDefaultBranch = testData?.defaultBranch === branch | ||
| const isTeamOrFreePlan = testData?.isTeamPlan || testData?.isFreePlan | ||
| // Only show flake rate column when on default branch for pro / enterprise plans or public repos | ||
| const [isDefaultBranch, setIsDefaultBranch] = useState(false) |
There was a problem hiding this comment.
what's up with all this stuff? Maybe we can do a use memo instead if we want to keep the state cached. Something like:
const isTeamOrFreePlan = useMemo(() => {
if (testData?.isTeamPlan !== null && testData?.isFreePlan !== null) {
return testData.isTeamPlan || testData.isFreePlan
}
return true // hide flake stuff by default maybe?
}, [testData?.isTeamPlan, testData?.isFreePlan])
etc. etc.
| 'flex-row-reverse': !['name', 'updatedAt'].includes( | ||
| header.id | ||
| ), | ||
| 'flex-row-reverse': header.id !== 'name', |
There was a problem hiding this comment.
we still want this change?
We're adding a time spent column to display the total time spent on each test for the selected time period. The goal is to give more granular information about the total impact of each test.