Skip to content

ref: decouple posting the PR comment and creating the message #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

  • recreates existing test results notifier build message implementation in standalone function
  • reimplements that using Jinja instead of simple string concatenation
  • reimplements BaseNotifier logic as simpler post_comment function

- recreates existing test results notifier build message implementation
  in standalone function
- reimplements that using Jinja instead of simple string concatenation
- reimplements BaseNotifier logic as simpler post_comment function
@joseph-sentry joseph-sentry force-pushed the joseph/ta-error-msg branch from ed17bcc to 574c093 Compare July 9, 2025 17:40
@joseph-sentry joseph-sentry requested a review from a team July 9, 2025 17:40
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 94.26230% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (3ff9444) to head (574c093).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/services/test_analytics/ta_notify.py 86.79% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   94.31%   94.31%   -0.01%     
==========================================
  Files        1229     1232       +3     
  Lines       45294    45378      +84     
  Branches     1448     1448              
==========================================
+ Hits        42721    42799      +78     
- Misses       2269     2275       +6     
  Partials      304      304              
Flag Coverage Δ
workerintegration 61.46% <50.00%> (-0.13%) ⬇️
workerunit 90.53% <94.26%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 94.26230% with 7 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/services/test_analytics/ta_notify.py 86.79% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant