-
Notifications
You must be signed in to change notification settings - Fork 3
feat: update error message formatting for clarity #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 94.31% 94.31% -0.01%
==========================================
Files 1232 1234 +2
Lines 45326 45361 +35
Branches 1449 1451 +2
==========================================
+ Hits 42751 42781 +30
- Misses 2271 2275 +4
- Partials 304 305 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=============================================
+ Coverage 50.00% 60.00% +10.00%
+ Complexity 11 10 -1
=============================================
Files 2 2
Lines 6 10 +4
Branches 0 1 +1
=============================================
+ Hits 3 6 +3
Misses 3 3
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2ef57b6
to
b58d886
Compare
- we want to remove the space between the MessagesToUserSection and the rest of the lines in the header section - we want to make the TA error message that shows up in the coverage PR comment shorter
b58d886
to
3ba1265
Compare
CodSpeed Performance ReportMerging #306 will not alter performanceComparing Summary
|
we replace some block quotes with simple emojis and generally use ✅ and ❌ for actual results pertaining to analytics and coverage, and⚠️ for issues with the uploads or setup
edit:
I refactored all the comment tests to use pytest insta snapshot testing
fixed the spacing issues in the new comment format
made the TA error message that shows up in the coverage comment shorter