Skip to content

feat: update error message formatting for clarity #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Jul 10, 2025

we replace some block quotes with simple emojis and generally use ✅ and ❌ for actual results pertaining to analytics and coverage, and ⚠️ for issues with the uploads or setup

edit:

I refactored all the comment tests to use pytest insta snapshot testing
fixed the spacing issues in the new comment format
made the TA error message that shows up in the coverage comment shorter

@joseph-sentry joseph-sentry requested a review from a team July 10, 2025 19:39
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (0f5e1f9) to head (3ba1265).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/services/test_results.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   94.31%   94.31%   -0.01%     
==========================================
  Files        1232     1234       +2     
  Lines       45326    45361      +35     
  Branches     1449     1451       +2     
==========================================
+ Hits        42751    42781      +30     
- Misses       2271     2275       +4     
- Partials      304      305       +1     
Flag Coverage Δ
apiunit 96.49% <ø> (+<0.01%) ⬆️
sharedintegration 39.71% <ø> (+0.04%) ⬆️
sharedunit 88.55% <ø> (-0.02%) ⬇️
workerintegration 61.57% <31.14%> (-0.02%) ⬇️
workerunit 90.60% <96.72%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/services/test_results.py 77.77% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@joseph-sentry
Copy link
Contributor Author

joseph-sentry commented Jul 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.00%. Comparing base (5b174c2) to head (5601846).
⚠️ Report is 2 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##               main       #9       +/-   ##
=============================================
+ Coverage     50.00%   60.00%   +10.00%     
+ Complexity       11       10        -1     
=============================================
  Files             2        2               
  Lines             6       10        +4     
  Branches          0        1        +1     
=============================================
+ Hits              3        6        +3     
  Misses            3        3               
- Partials          0        1        +1     
Flag Coverage Δ Complexity Δ
integration ? ?
unit 100.00% <ø> (?) 0.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry force-pushed the joseph/improve-comment branch from 2ef57b6 to b58d886 Compare July 11, 2025 18:33
- we want to remove the space between the MessagesToUserSection and the rest of
  the lines in the header section
- we want to make the TA error message that shows up in the coverage PR comment
  shorter
@joseph-sentry joseph-sentry force-pushed the joseph/improve-comment branch from b58d886 to 3ba1265 Compare July 11, 2025 18:42
Copy link

codspeed-hq bot commented Jul 11, 2025

CodSpeed Performance Report

Merging #306 will not alter performance

Comparing joseph/improve-comment (3ba1265) with main (120c2c9)

Summary

✅ 9 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants