Update conditionalAccessGapAnalyzer.workbook #2903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conditionalAccessGapAnalyzer.workbook is including "Windows SignIn" that doesn't support MFA, so it doesn't have sense to be included in the report. There was also request for this change: microsoft#1824
Escaped quotations.
|
@sabinasmith, @gardnerjr please check, if there is anything I need to do to merge my changes. |
|
@miritsadon can you please review my changes? |
|
I was on vacation will take a look today
…On Tue, 1 Apr 2025 at 20:23 Palciny ***@***.***> wrote:
@miritsadon <https://github.com/miritsadon> can you please review my
changes?
—
Reply to this email directly, view it on GitHub
<#2903 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUQOCI2OLF4YZ3YPMKZBOH32XLDPVAVCNFSM6AAAAABXETY6S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZQGEZDSMJQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
[image: Palciny]*Palciny* left a comment
(microsoft/Application-Insights-Workbooks#2903)
<#2903 (comment)>
@miritsadon <https://github.com/miritsadon> can you please review my
changes?
—
Reply to this email directly, view it on GitHub
<#2903 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUQOCI2OLF4YZ3YPMKZBOH32XLDPVAVCNFSM6AAAAABXETY6S6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZQGEZDSMJQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
miritsadon
approved these changes
Apr 3, 2025
miritsadon
reviewed
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
conditionalAccessGapAnalyzer.workbook is including "Windows SignIn" that doesn't support MFA, so it doesn't have sense to be included in the report.
There was also request for this change: #1824
Screenshots
I have tested my template content.