Exclude tasks that should not run from the dep graph #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I haven't been able to run the tests yet, I ran into some problems that I opened an issue about. So this hasn't updated the tests, yet. But I thought I could open the PR to get feedback on the approach anyway. Just in case this needs to be re-written. But in any case I'll have to figure out the issue with the tests. |
|
I'm not sure this covers all the cases I want. For example, it would be nice to have |
If a task should not run, it shouldn't generate dependencies, either. For example if we have a task "bundle" which depends on "build", running the "bundle" task should not run "build" in workspaces that do not have a "bundle" task in them.
dobesv
force-pushed
the
exclude-nonrunning-deps
branch
from
ad6882f to
35f293c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a task should not run, it shouldn't generate dependencies, either.
For example if we have a task "bundle" which depends on "build", running the "bundle" task should not run "build" in workspaces that do not have a "bundle" task in them.