Skip to content

Fix issue with tests failing during cleanup #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dobesv
Copy link

@dobesv dobesv commented Apr 1, 2025

The temp folder was deleted before the write stream would close, and it would cause node to exit due to an unhandled error.

Fixes #864

@dobesv dobesv requested a review from kenotron as a code owner April 1, 2025 00:22
@dobesv
Copy link
Author

dobesv commented Apr 1, 2025

@kenotron @ecraig12345 I opened a few PRs but no response - should I continue to try and contribute to the project or should I figure out something on my own, like make a fork to use so I can get these bugfixes applied?

@ecraig12345
Copy link
Member

@kenotron @ecraig12345 I opened a few PRs but no response - should I continue to try and contribute to the project or should I figure out something on my own, like make a fork to use so I can get these bugfixes applied?

Thanks for the contributions! I asked @kenotron to take a look, since I help some with maintenance but haven't actually worked on the core logic of Lage (so I don't know the nuances of which current behaviors were intended or not, or what implications changes might have).

dobesv added 3 commits April 18, 2025 21:25
The temp folder was deleted before the write stream would close, and it would cause node to exit due to an unhandled error.
@dobesv dobesv force-pushed the fix-reporter-tests-cleanup branch from 0b0f612 to c414608 Compare April 19, 2025 04:33
@dobesv
Copy link
Author

dobesv commented May 6, 2025

Any update on the status of the project? I'm running into more issues and I wonder if I should expend any more effort on using or contributing to this project. @kenotron @ecraig12345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having trouble running lage tests
2 participants