Add Shared Shared Crypto Support #131
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule name is incorrect and pointing at mu_plus instead of MU.
This commit updates the MU_BASECORE submodule to point to the latest commit. This removes an issue with zeex/subhooks submodule that was causing the build to fail.
Added casting to prevent shift left of 8 bits (equal to size of type). (similar to what's been done in other places, e.g. https://github.com/microsoft/mu_basecore/blob/fabbe775f9c6e375174067ea2df1e50ecb9bad50/MdePkg/Include/Ppi/PciCfg2.h#L29)
github-actions
bot
added
language:python
Flickdm
changed the title
Flickdm
force-pushed
the
feature/add/shared_crypto_support
branch
from
2935a07 to
7d86bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is not ready to be merged but represents the changes needed to build a standalone crypto binary
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
TODO
Support Branches:
Flickdm/mu_basecore#4
microsoft/mu_tiano_platforms#1141
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>