-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Update deprecated CCCL API #25246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated CCCL API #25246
Conversation
@microsoft-github-policy-service agree |
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
Azure Pipelines successfully started running 5 pipeline(s). |
@mc-nv , it has some build failures. Please fix them. |
CI pipeline is using CUDA 12.2, which does not have ::cuda::maximum(). Need code like the following to fix build error:
|
@snnn where I can find build environment configuration, or may be you can provide the version of CCCL installed. Why we asking for it because CCCL API deprecation was introduced in version 2.8.0 |
People are even asking for CUDA 11.x support. #25182 I think we still need to make the source code be compatible with CUDA 12.2 before the next release is done. Then we can discuss upgrading. |
got it I will address those changes and get back to this PR |
/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline |
Azure Pipelines successfully started running 5 pipeline(s). |
I'm afraid I need to push one more commit towards to this change... |
That's fine. Welcome to submit a new PR. |
I tested Windows build using cuda 12.9 with/without this PR. Both are good. CUDA_VERSION is defined in cuda.h; CUDART_VERSION is defined in cuda_runtime_api.h. It is better to include cuda.h or cuda_runtime_api.h explicitly. |
Description
Update API
Motivation and Context
Address issues for: #24774