Skip to content

Update deprecated CCCL API #25246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 8, 2025
Merged

Conversation

mc-nv
Copy link
Contributor

@mc-nv mc-nv commented Jul 1, 2025

Description

Update API

Motivation and Context

Address issues for: #24774

@mc-nv
Copy link
Contributor Author

mc-nv commented Jul 1, 2025

@microsoft-github-policy-service agree

@snnn
Copy link
Member

snnn commented Jul 3, 2025

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

snnn
snnn previously approved these changes Jul 3, 2025
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@snnn snnn dismissed their stale review July 3, 2025 20:26

Has build failures

@snnn
Copy link
Member

snnn commented Jul 3, 2025

@mc-nv , it has some build failures. Please fix them.

@tianleiwu
Copy link
Contributor

CI pipeline is using CUDA 12.2, which does not have ::cuda::maximum(). Need code like the following to fix build error:

#if CUDA_VERSION >= 12090
::cuda::minimum<int> min;
#else
// Deprecated on CUDA 12.9
cub::Min min;
#endif

@mc-nv
Copy link
Contributor Author

mc-nv commented Jul 3, 2025

@snnn where I can find build environment configuration, or may be you can provide the version of CCCL installed.
At glance build uses CUDA 12.2 which 18 month old for NVIDIA.
Will it be possible to validate changes within 12.9 build environment?

Why we asking for it because CCCL API deprecation was introduced in version 2.8.0
https://github.com/NVIDIA/cccl/releases/tag/v2.8.0
And that version is 4 month old.

@snnn
Copy link
Member

snnn commented Jul 3, 2025

People are even asking for CUDA 11.x support. #25182

I think we still need to make the source code be compatible with CUDA 12.2 before the next release is done. Then we can discuss upgrading.

@mc-nv
Copy link
Contributor Author

mc-nv commented Jul 3, 2025

got it I will address those changes and get back to this PR

@mc-nv mc-nv force-pushed the mc-nv/cccl-api-fix branch from 86533be to dcced48 Compare July 5, 2025 14:19
@tianleiwu
Copy link
Contributor

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@tianleiwu tianleiwu requested a review from snnn July 8, 2025 18:10
@mc-nv
Copy link
Contributor Author

mc-nv commented Jul 8, 2025

I'm afraid I need to push one more commit towards to this change...

@tianleiwu tianleiwu merged commit a2bd54b into microsoft:main Jul 8, 2025
85 checks passed
@snnn
Copy link
Member

snnn commented Jul 8, 2025

That's fine. Welcome to submit a new PR.

@tianleiwu
Copy link
Contributor

I tested Windows build using cuda 12.9 with/without this PR. Both are good.

CUDA_VERSION is defined in cuda.h; CUDART_VERSION is defined in cuda_runtime_api.h. It is better to include cuda.h or cuda_runtime_api.h explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants