Skip to content

Fix antialias downsample on CUDA EP #25265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amancini-N
Copy link
Contributor

Description

This PR addresses 3 issues:

  • Compilation errors when DISABLE_CONTRIB_OPS flag is on
  • Solve a CUDA compute kernel setup issue on Resize op with cubic filter and antialiasing
  • Solve cubic_coeff_a parameter being ignored in CUDA kernel of Resize op

Motivation and Context

#25264

@tianleiwu
Copy link
Contributor

/azp run Linux QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@tianleiwu tianleiwu requested a review from yuslepukhin July 3, 2025 21:45
@yuslepukhin yuslepukhin requested a review from xadupre July 3, 2025 22:29
@@ -98,6 +98,7 @@ void ResizeAntiAliasImpl(
int rank,
const UpsampleMode upsample_mode,
ResizeCoordinateTransformationMode coordinate_transform_mode,
const float cubic_coeff_a,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cons

const is unnecessary

@yuslepukhin
Copy link
Member

I think this comment needs to be addressed: #25264 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants