Fix Sign and Clip operation on int64 tensors #25280
Open
+72
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Bourjau <christian.bourjau@quantco.com>
cbourjau
changed the title
Signed-off-by: Christian Bourjau <christian.bourjau@quantco.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,33 @@ | |||
| import numpy as np | |||
| import onnx | |||
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note test
| @@ -0,0 +1,32 @@ | |||
| import numpy as np | |||
| import onnx | |||
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note test
tianleiwu
reviewed
Jul 7, 2025
| .cwiseMin(max_val); | ||
| .array() | ||
| .unaryExpr([=](auto x) { | ||
| return std::clamp(x, min_val, max_val); |
There was a problem hiding this comment.
It will not get expected result when min_val > max_val. std::clamp will return x in this case, while onnx definition is Min(max_value, Max(x, min_value)) will return max_value.
|
/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 5 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Clip and sign operators exhibit buggy behavior for some int64 values on Linux and Windows (see added test cases). Using Eigen's Array-API appears to mitigate the issue. A failing test case on CI can be found here (uses the conda-forge toolchain).