[EP ABI] Utility to serialize OrtGraph to GraphProto #25292
+1,079
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to return the attribute names that correspond to each subgraph.
… the original model
adrianlizarraga
commented
Jul 6, 2025
| * | ||
| * \since Version 1.23. | ||
| */ | ||
| ORT_API2_STATUS(Graph_GetNumOperatorSets, _In_ const OrtGraph* graph, _Out_ size_t* num_operator_sets); |
There was a problem hiding this comment.
Note: "Operator set" is terminology from ONNX: https://github.com/onnx/onnx/blob/3236bf77da50c6bd365e7a3d0e79ef47acace640/onnx/onnx.proto#L888-L901
ORT also uses "domain opset versions". Not sure which is clearer.
|
Thanks @adrianlizarraga! we should discuss with @chilo-ms where the utility functions should live. there are several options. |
chilo-ms
previously approved these changes
Jul 7, 2025
|
@chilo-ms @jywu-msft , I made this a header-only file that can be copied into a project that builds with ORT + ONNX. I moved it into Please let me know if you have any feedback. Thanks. |
adrianlizarraga
commented
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrtGraphto aGraphProtoorModelProto.Node_GetSubgraphsAPI function to also return the attribute names associated with each subgraph. This is required to determine which subgraph corresponds to a given attribute.Graph_GetNumOperatorSetsandGraph_GetOperatorSetsAPI functions to get the opset version for each domain.Motivation and Context
Provide a utility to facilitate porting of existing execution providers to the new EP ABI. The utilities introduced by this PR convert an
OrtGraphinto an ONNX protobuf representation, which some existing EPs currently convert to their internal representation. Ideally, we would prefer a more direct conversion from aOrtGraphto the EP's internal representation, but this is a large effort. These utilities enable an incremental transition.