Skip to content

FIX printDebugInfo in ov_interface.cc #25298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Conversation

JulienMaille
Copy link
Contributor

error C2181: illegal else without matching if

Fix compilation in debug due to {} mismatch

@JulienMaille JulienMaille marked this pull request as ready for review July 6, 2025 15:59
@fs-eire
Copy link
Contributor

fs-eire commented Jul 7, 2025

Please use clang-format to format the code

@JulienMaille
Copy link
Contributor Author

@fs-eire the whole file is weirdly formatted, regarding the bit I fixed I have followed the same formatting.
BTW do you have a pipeline that build with OpenVino in debug? This bug with {} should never have been committed.

@fs-eire
Copy link
Contributor

fs-eire commented Jul 7, 2025

There is one. But I think the build pipeline only build release so the code is never included

@JulienMaille
Copy link
Contributor Author

I’m not sure how to format or indent my fix without conflicting with the formatting of the surrounding code.

@fs-eire
Copy link
Contributor

fs-eire commented Jul 7, 2025

I’m not sure how to format or indent my fix without conflicting with the formatting of the surrounding code.

I checked it locally. you are right, the file is not initially well formated. The Lint job only checks modified files. It's OK to commit the file after formatting a lot of lines - it should have been formatted before.

error C2181: illegal else without matching if
@JulienMaille
Copy link
Contributor Author

@fs-eire Done

@fs-eire
Copy link
Contributor

fs-eire commented Jul 8, 2025

/azp run Linux QNN CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@fs-eire fs-eire merged commit b6ce761 into microsoft:main Jul 8, 2025
96 of 97 checks passed
@JulienMaille JulienMaille deleted the patch-2 branch July 8, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants