Skip to content

ada-url 3.2.5 #228652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

ada-url 3.2.5 #228652

merged 2 commits into from
Jul 7, 2025

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
## What's Changed
* cleaner CMake file: add options by @lemire in https://github.com/ada-url/ada/pull/946
* Bump github/codeql-action from 3.28.13 to 3.28.16 by @dependabot in https://github.com/ada-url/ada/pull/950
* Bump uraimo/run-on-arch-action from 3.0.0 to 3.0.1 by @dependabot in https://github.com/ada-url/ada/pull/949
* Bump actions/setup-python from 5.5.0 to 5.6.0 by @dependabot in https://github.com/ada-url/ada/pull/948
* Bump actions/setup-node from 4.3.0 to 4.4.0 by @dependabot in https://github.com/ada-url/ada/pull/951
* Bump actions/dependency-review-action from 4.5.0 to 4.6.0 by @dependabot in https://github.com/ada-url/ada/pull/947
* Bump actions/checkout from 3 to 4 by @dependabot in https://github.com/ada-url/ada/pull/953
* Bump github/codeql-action from 3.28.16 to 3.28.18 by @dependabot in https://github.com/ada-url/ada/pull/952
* Bump ossf/scorecard-action from 2.4.1 to 2.4.2 by @dependabot in https://github.com/ada-url/ada/pull/954
* Bump actions/dependency-review-action from 4.6.0 to 4.7.1 by @dependabot in https://github.com/ada-url/ada/pull/955
* faster and smaller adaparse by @lemire in https://github.com/ada-url/ada/pull/956
* feat: Optimize `to_string` by @mertcanaltin in https://github.com/ada-url/ada/pull/959
* fix(url): handle tab/newline-only inputs in set_port by @watilde in https://github.com/ada-url/ada/pull/961
* Update web platform tests (url) by @anonrig in https://github.com/ada-url/ada/pull/962
* fix(url): handle :port values in host setter by @watilde in https://github.com/ada-url/ada/pull/963
* Update web platform tests (url) by @anonrig in https://github.com/ada-url/ada/pull/964
* More portable PIC by @lemire in https://github.com/ada-url/ada/pull/966
* perf: use simdutf for idna by @CarlosEduR in https://github.com/ada-url/ada/pull/960
* chore: release v3.2.5 by @github-actions in https://github.com/ada-url/ada/pull/965

New Contributors

Full Changelog: ada-url/ada@v3.2.4...v3.2.5

View the full release notes at https://github.com/ada-url/ada/releases/tag/v3.2.5.


@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jul 1, 2025
@chenrui333
Copy link
Member

   ==> /home/linuxbrew/.linuxbrew/bin/g++-15 test.cpp -std=c++20 -I/home/linuxbrew/.linuxbrew/Cellar/ada-url/3.2.5/include -L/home/linuxbrew/.linuxbrew/Cellar/ada-url/3.2.5/lib -lada -o test
  /var/tmp/ccVp85YF.s: Assembler messages:
  /var/tmp/ccVp85YF.s:346: Error: unknown pseudo-op: `.base64'
  /var/tmp/ccVp85YF.s:351: Error: unknown pseudo-op: `.base64'
  /var/tmp/ccVp85YF.s:356: Error: unknown pseudo-op: `.base64'
  /var/tmp/ccVp85YF.s:361: Error: unknown pseudo-op: `.base64'
  /var/tmp/ccVp85YF.s:366: Error: unknown pseudo-op: `.base64'
  /var/tmp/ccVp85YF.s:371: Error: unknown pseudo-op: `.base64'
  /var/tmp/ccVp85YF.s:376: Error: unknown pseudo-op: `.base64'

@chenrui333 chenrui333 added test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 1, 2025
@chenrui333 chenrui333 force-pushed the bump-ada-url-3.2.5 branch from 0364401 to 4f5dbdc Compare July 1, 2025 16:12
@anonrig
Copy link
Contributor

anonrig commented Jul 2, 2025

@lemire any suggestions why the latest version is failing?

@lemire
Copy link

lemire commented Jul 2, 2025

base64 does not appear in our codebase...

https://github.com/search?q=repo%3Aada-url%2Fada%20base64&type=code

@anonrig
Copy link
Contributor

anonrig commented Jul 3, 2025

base64 does not appear in our codebase...

https://github.com/search?q=repo%3Aada-url%2Fada%20base64&type=code

@lemire But simdutf is part of our repo. Home brew uses cmake.

@lemire
Copy link

lemire commented Jul 3, 2025

@anonrig I am not sure.

The simdutf library is part of brew as well.

@lemire
Copy link

lemire commented Jul 3, 2025

@anonrig It seems that simdutf is OFF by default in ada, right now. Do you expect simdutf to be involved in this issue?

@lemire
Copy link

lemire commented Jul 3, 2025

The issue appears to be specific to Linux.

@lemire
Copy link

lemire commented Jul 3, 2025

I do not think that this is an issue with ada. I believe that the Linux brew CI is likely misconfigured, with a mismatch of the assembler and the compiler.

@lemire
Copy link

lemire commented Jul 3, 2025

Here is what is likely happening. The compiler (GCC 15) emits the .base64 pseudo-instruction and then an older version of gas (the assembler) which does not support .base64 is called.

The issue is that brew is not careful when it configures GCC 15 to make sure that it (GCC 15) also uses the right assembler.

This has been reported to brew by @c-kloukinas :

https://github.com/orgs/Homebrew/discussions/6229

@lemire
Copy link

lemire commented Jul 3, 2025

You can see the new feature being requested and provided here:

https://sourceware.org/bugzilla/show_bug.cgi?id=31964

This is a brand new feature that requires a matching assembler.

@lemire
Copy link

lemire commented Jul 3, 2025

More at:

Daniel Lemire, "Base64 for compression," in Daniel Lemire's blog, July 3, 2025, https://lemire.me/blog/2025/07/03/base64-for-compression/.

Copy link
Contributor

github-actions bot commented Jul 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jul 6, 2025
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@carlocab carlocab force-pushed the bump-ada-url-3.2.5 branch from 4f5dbdc to 7b9845b Compare July 7, 2025 10:15
@github-actions github-actions bot removed the stale No recent activity label Jul 7, 2025
@daeho-ro daeho-ro removed the test failure CI fails while running the test-do block label Jul 7, 2025
Copy link
Contributor

github-actions bot commented Jul 7, 2025

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 7, 2025
@BrewTestBot BrewTestBot enabled auto-merge July 7, 2025 11:09
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 7a27133 Jul 7, 2025
17 checks passed
@BrewTestBot BrewTestBot deleted the bump-ada-url-3.2.5 branch July 7, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants