-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
ollama: bind it to all network interfaces #228860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@leandrofavarin can you amend your commit msg as |
Do we really want this to be available to everyone on the same network? We have additional configuration for MySQL to avoid making it public, so it seems odd to me to enable this by default. |
I understand the argument that MySQL isn’t automatically exposed to the public network by default. That’s generally true and a good security practice. Most of the utility of a database is to host private data, after all. Ollama however, hosts models that are already public. Its "Intended Use" is a little distinct. Network access for it could be considered a feature, and not a vulnerability. |
From Ollama [0.9.4](https://github.com/ollama/ollama/releases/tag/v0.9.4): >Expose Ollama on the network >Ollama can now be exposed on the network, allowing others to access Ollama on other devices or even over the internet. This is useful for having Ollama running on a powerful Mac, PC or Linux computer while making it accessible to less powerful devices. Allowing the formula to do the same seems like a good idea.
Thanks @carlocab for the amend 🙏 |
Is there something I can do to get the attention of someone who can approve this PR? |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?From Ollama v0.9.4:
Allowing the formula to do the same seems like a good idea.