Skip to content

ollama: bind it to all network interfaces #228860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leandrofavarin
Copy link

@leandrofavarin leandrofavarin commented Jul 2, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

From Ollama v0.9.4:

Expose Ollama on the network
Ollama can now be exposed on the network, allowing others to access Ollama on other devices or even over the internet. This is useful for having Ollama running on a powerful Mac, PC or Linux computer while making it accessible to less powerful devices.

Allowing the formula to do the same seems like a good idea.

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Jul 2, 2025
@leandrofavarin leandrofavarin changed the title Bind Ollama to all network interfaces ollama: Bind it to all network interfaces Jul 2, 2025
@leandrofavarin leandrofavarin changed the title ollama: Bind it to all network interfaces ollama: bind it to all network interfaces Jul 2, 2025
@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jul 2, 2025
@chenrui333
Copy link
Member

@leandrofavarin can you amend your commit msg as ollama: bind it to all network interfaces? Thanks!

@SMillerDev
Copy link
Member

SMillerDev commented Jul 2, 2025

Do we really want this to be available to everyone on the same network? We have additional configuration for MySQL to avoid making it public, so it seems odd to me to enable this by default.

@leandrofavarin
Copy link
Author

leandrofavarin commented Jul 2, 2025

Do we really want this to be available to everyone on the same network? We have additional configuration for MySQL to avoid making it public, so it seems odd to me to enable this by default.

I understand the argument that MySQL isn’t automatically exposed to the public network by default. That’s generally true and a good security practice. Most of the utility of a database is to host private data, after all.

Ollama however, hosts models that are already public. Its "Intended Use" is a little distinct. Network access for it could be considered a feature, and not a vulnerability.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 2, 2025
From Ollama [0.9.4](https://github.com/ollama/ollama/releases/tag/v0.9.4):

>Expose Ollama on the network
>Ollama can now be exposed on the network, allowing others to access Ollama on other devices or even over the internet. This is useful for having Ollama running on a powerful Mac, PC or Linux computer while making it accessible to less powerful devices.

Allowing the formula to do the same seems like a good idea.
@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. labels Jul 3, 2025
@carlocab carlocab removed the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jul 3, 2025
@leandrofavarin
Copy link
Author

Thanks @carlocab for the amend 🙏

@leandrofavarin
Copy link
Author

Is there something I can do to get the attention of someone who can approve this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants