Skip to content

Update dropdown labeling guidance to internal article #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marcysutton
Copy link
Member

Summary:

I got feedback from the Content team that the w3c-WAI article linked from the editor was too technical for the audience. So I created an internal doc that we can maintain, that also links to the previous article for those who are curious.

Issue: FEI-6288

Test plan:

  1. Ensure the links work (the doc is on Confluence)
  2. Ensure the link text fits ("this internal article" instead of "this article")

@marcysutton marcysutton self-assigned this May 19, 2025
Copy link
Contributor

Size Change: +20 B (0%)

Total Size: 471 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 89.6 kB +20 B (+0.02%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.7 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 5.98 kB
packages/math-input/dist/es/index.js 98.6 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.js 19.4 kB
packages/perseus-linter/dist/es/index.js 7.05 kB
packages/perseus-score/dist/es/index.js 9.15 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/index.js 202 kB
packages/perseus/dist/es/strings.js 7.61 kB
packages/pure-markdown/dist/es/index.js 1.22 kB
packages/simple-markdown/dist/es/index.js 6.72 kB

compressed-size-action

Copy link
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (8503d21) and published it to npm. You
can install it using the tag PR2504.

Example:

pnpm add @khanacademy/perseus@PR2504

If you are working in Khan Academy's webapp, you can run the below command.
If this is for backend code, change the static flag (-s) from y/yes to n/no.

./dev/tools/bump_perseus_version.js -s y -t PR2504

target="_blank"
rel="noreferrer"
>
this article.
this internal article.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one question is: can we link to an internal article in this project? Or am I not adequately considering external audiences since this is an OS project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant