Open
Description
Description:
devEngines
field is now supported by npm and corepack.
If user set node-version-file: package.json
in yaml, setup-node
action should consult both engines
and devEngines
fields, while currently only engines
works.
Justification:
In monorepo, the root package.json usually have no engines
field. Moreover, the engines
is for users who install the npm package, while the devEngines
field is for who developers who develop the npm package. Obviously, devEngines
is more suitable for setup-node
.
Are you willing to submit a PR?
Yes
Activity
suyashgaonkar commentedon Mar 24, 2025
Hi @zanminkian , Thank you for creating this feature request. We will investigate it and provide feedback as soon as we have some updates.
mklueh commentedon Apr 13, 2025
And if anyone is working on this, maybe you could also consider factoring in the volta node field?
Then you could run
volta pin node@23.11.0
which would fetch and install node, set the node version in package.jsonvolta.node
and that's all you have to dohttps://docs.volta.sh/reference/pin
But maybe it would be better to let volta handle the devEngines update instead of making this action volta-aware
susnux commentedon Apr 20, 2025
@mklueh but the volta field is already supported? #921
devEngines
field #1283