Skip to content

Support devEngines field in package.json #1255

Open
@zanminkian

Description

@zanminkian

Description:
devEngines field is now supported by npm and corepack.

If user set node-version-file: package.json in yaml, setup-node action should consult both engines and devEngines fields, while currently only engines works.

Justification:
In monorepo, the root package.json usually have no engines field. Moreover, the engines is for users who install the npm package, while the devEngines field is for who developers who develop the npm package. Obviously, devEngines is more suitable for setup-node.

Are you willing to submit a PR?
Yes

Activity

suyashgaonkar

suyashgaonkar commented on Mar 24, 2025

@suyashgaonkar
Contributor

Hi @zanminkian , Thank you for creating this feature request. We will investigate it and provide feedback as soon as we have some updates.

mklueh

mklueh commented on Apr 13, 2025

@mklueh

And if anyone is working on this, maybe you could also consider factoring in the volta node field?

Image

Then you could run volta pin node@23.11.0 which would fetch and install node, set the node version in package.json volta.node and that's all you have to do

https://docs.volta.sh/reference/pin

But maybe it would be better to let volta handle the devEngines update instead of making this action volta-aware

susnux

susnux commented on Apr 20, 2025

@susnux

@mklueh but the volta field is already supported? #921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestNew feature or request to improve the current logic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @mklueh@susnux@zanminkian@suyashgaonkar

      Issue actions

        Support `devEngines` field in `package.json` · Issue #1255 · actions/setup-node