-
Notifications
You must be signed in to change notification settings - Fork 388
Introducing sort-issues-by option #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
suyashgaonkar
wants to merge
17
commits into
actions:main
Choose a base branch
from
suyashgaonkar:sort_issues_by
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new sort-issues-by
option so users can control how issues are ordered (by creation date, last update, or comment count).
- Parses
sort-issues-by
input and wires it through the options interface. - Registers the option in the enum and action metadata.
- Implements sort logic in the GitHub API call and provides defaults in tests.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/main.ts | Parse sort-issues-by from action inputs |
src/interfaces/issues-processor-options.ts | Add sortIssuesBy property to options interface |
src/enums/option.ts | Add SortIssuesBy enum entry |
src/classes/issues-processor.ts | Use sortIssuesBy to set the API sort parameter |
src/classes/issue.spec.ts | Initialize default sortIssuesBy in tests |
action.yml | Declare the new sort-issues-by input |
tests/constants/default-processor-options.ts | Include default sortIssuesBy in defaults |
Comments suppressed due to low confidence (1)
src/classes/issues-processor.ts:574
- There are no tests verifying how different
sortIssuesBy
values (updated
,comments
) affect the API request. Add unit tests to ensure each option sends the correctsort
parameter.
sort:
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introducing a new option
sort-issues-by
to sort the issues by the specified field. It accepts 'created', 'updated', 'comments' as values and default value is set to 'created', defines the sorting order of the issues in a repository.Related issue:
Related to #1231
Check list: