Skip to content

docs(patternhub): use monospace font-family for code styling #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 1, 2025
Merged

docs(patternhub): use monospace font-family for code styling #4365

merged 9 commits into from
Jul 1, 2025

Conversation

d-koppenhagen
Copy link
Contributor

@d-koppenhagen d-koppenhagen commented Jun 11, 2025 •
edited by mfranzke
Loading

Proposed changes

use monospace font-family for code styling

compare to e.g. Button documentation

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

Relates to #4221

Before After
Before Image 1 After Image 1
Before Image 2 After Image 2

@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ux-design-system.github.io/core-web/review/docs-code-style

@mfranzke mfranzke added 🍄🆙improvement New feature or request 👩‍👧‍👦communityFeedback Feedback from community labels Jun 11, 2025
@mfranzke mfranzke moved this to 👀 In review in UX Engineering Team Backlog Jun 11, 2025
mfranzke
mfranzke reviewed Jun 12, 2025
View reviewed changes
@mfranzke
Copy link
Collaborator

@nmerget is there a reason for that we include the code-HTML-element in the global font-CSS-declaration and thatfor assigning the DB font to it ?

@mfranzke mfranzke requested a review from Copilot June 16, 2025 05:08
Copilot
Copilot AI reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to update code styling in documentation by applying a monospace font-family to code elements.

  • Updated SCSS selectors targeting code elements within pre tags
  • Adjusted styling rules to support consistent code presentation

nmerget and others added 3 commits June 27, 2025 14:48
mfranzke
mfranzke reviewed Jun 27, 2025
View reviewed changes
nmerget and others added 5 commits June 30, 2025 13:14
@nmerget
fix: issue with wrong patternhub snapshots
1b65e41
@nmerget
Merge branch 'main' into docs-code-style
1ed61c3
@github-actions
auto update snapshots (#4440)
af6570c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mfranzke
Merge branch 'main' into docs-code-style
e00461e
@nmerget
Merge remote-tracking branch 'origin/main' into docs-code-style
6118050 
# Conflicts:
#	__snapshots__/foundations/accordion-item/patternhub/accordion-item-docs-should-match-screenshot.png
#	__snapshots__/foundations/accordion/patternhub/accordion-docs-should-match-screenshot.png
#	__snapshots__/foundations/accordion/patternhub/accordion-properties-should-match-screenshot.png
#	__snapshots__/foundations/badge/patternhub/badge-docs-should-match-screenshot.png
#	__snapshots__/foundations/badge/patternhub/badge-properties-should-match-screenshot.png
#	__snapshots__/foundations/brand/patternhub/brand-docs-should-match-screenshot.png
#	__snapshots__/foundations/brand/patternhub/brand-properties-should-match-screenshot.png
#	__snapshots__/foundations/button/patternhub/button-docs-should-match-screenshot.png
#	__snapshots__/foundations/button/patternhub/button-properties-should-match-screenshot.png
#	__snapshots__/foundations/card/patternhub/card-docs-should-match-screenshot.png
#	__snapshots__/foundations/card/patternhub/card-properties-should-match-screenshot.png
#	__snapshots__/foundations/checkbox/patternhub/checkbox-docs-should-match-screenshot.png
#	__snapshots__/foundations/checkbox/patternhub/checkbox-properties-should-match-screenshot.png
#	__snapshots__/foundations/custom-select/patternhub/custom-select-docs-should-match-screenshot.png
#	__snapshots__/foundations/custom-select/patternhub/custom-select-properties-should-match-screenshot.png
#	__snapshots__/foundations/divider/patternhub/divider-docs-should-match-screenshot.png
#	__snapshots__/foundations/divider/patternhub/divider-properties-should-match-screenshot.png
#	__snapshots__/foundations/drawer/patternhub/drawer-docs-should-match-screenshot.png
#	__snapshots__/foundations/drawer/patternhub/drawer-properties-should-match-screenshot.png
#	__snapshots__/foundations/header/patternhub/header-docs-should-match-screenshot.png
#	__snapshots__/foundations/header/patternhub/header-properties-should-match-screenshot.png
#	__snapshots__/foundations/infotext/patternhub/infotext-docs-should-match-screenshot.png
#	__snapshots__/foundations/infotext/patternhub/infotext-properties-should-match-screenshot.png
#	__snapshots__/foundations/input/patternhub/input-docs-should-match-screenshot.png
#	__snapshots__/foundations/link/patternhub/link-docs-should-match-screenshot.png
#	__snapshots__/foundations/link/patternhub/link-properties-should-match-screenshot.png
#	__snapshots__/foundations/navigation-item/patternhub/navigation-item-docs-should-match-screenshot.png
#	__snapshots__/foundations/navigation-item/patternhub/navigation-item-properties-should-match-screenshot.png
#	__snapshots__/foundations/navigation/patternhub/navigation-docs-should-match-screenshot.png
#	__snapshots__/foundations/navigation/patternhub/navigation-properties-should-match-screenshot.png
#	__snapshots__/foundations/notification/patternhub/notification-docs-should-match-screenshot.png
#	__snapshots__/foundations/popover/patternhub/popover-docs-should-match-screenshot.png
#	__snapshots__/foundations/popover/patternhub/popover-properties-should-match-screenshot.png
#	__snapshots__/foundations/radio/patternhub/radio-docs-should-match-screenshot.png
#	__snapshots__/foundations/radio/patternhub/radio-properties-should-match-screenshot.png
#	__snapshots__/foundations/section/patternhub/section-docs-should-match-screenshot.png
#	__snapshots__/foundations/section/patternhub/section-properties-should-match-screenshot.png
#	__snapshots__/foundations/select/patternhub/select-docs-should-match-screenshot.png
#	__snapshots__/foundations/stack/patternhub/stack-docs-should-match-screenshot.png
#	__snapshots__/foundations/stack/patternhub/stack-properties-should-match-screenshot.png
#	__snapshots__/foundations/switch/patternhub/switch-docs-should-match-screenshot.png
#	__snapshots__/foundations/switch/patternhub/switch-properties-should-match-screenshot.png
#	__snapshots__/foundations/tab-item/patternhub/tab-item-docs-should-match-screenshot.png
#	__snapshots__/foundations/tab-item/patternhub/tab-item-properties-should-match-screenshot.png
#	__snapshots__/foundations/tabs/patternhub/tabs-docs-should-match-screenshot.png
#	__snapshots__/foundations/tabs/patternhub/tabs-properties-should-match-screenshot.png
#	__snapshots__/foundations/tag/patternhub/tag-docs-should-match-screenshot.png
#	__snapshots__/foundations/tag/patternhub/tag-properties-should-match-screenshot.png
#	__snapshots__/foundations/textarea/patternhub/textarea-docs-should-match-screenshot.png
#	__snapshots__/foundations/tooltip/patternhub/tooltip-docs-should-match-screenshot.png
#	__snapshots__/foundations/tooltip/patternhub/tooltip-properties-should-match-screenshot.png
@nmerget nmerget enabled auto-merge (squash) July 1, 2025 11:24
@nmerget nmerget merged commit 57fd48a into main Jul 1, 2025
76 checks passed
@nmerget nmerget deleted the docs-code-style branch July 1, 2025 12:01
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in UX Engineering Team Backlog Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke left review comments

Copilot code review Copilot Copilot left review comments

@nmerget nmerget nmerget approved these changes

Assignees
No one assigned
Labels
👩‍👧‍👦communityFeedback Feedback from community 🍄🆙improvement New feature or request
Projects
UX Engineering Team Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-koppenhagen @mfranzke @nmerget