[.Net10][Proposal]TabbedPage - TabActiveTapped event #30445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new TabReselected event to TabbedPage so that taps on the currently active tab can be handled consistently across platforms.
- Adds the
TabReselectedevent and anOnTabReselectedinvoker in the sharedTabbedPageclass. - Hooks into Android’s
TabbedPageManagerand iOS’s compatibilityTabbedRendererto raise the event on reselection. - Updates
PublicAPI.Unshipped.txtfor all frameworks to expose the new event.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/src/Core/TabbedPage/TabbedPage.cs | Added TabReselected event and OnTabReselected method |
| src/Controls/src/Core/Platform/Android/TabbedPageManager.cs | Invoke OnTabReselected on bottom‐nav and tab reselection |
| src/Controls/src/Core/Compatibility/Handlers/TabbedPage/iOS/TabbedRenderer.cs | Override ViewDidLoad to wire up tab reselection callback |
| src/Controls/src/Core/PublicAPI/**/PublicAPI.Unshipped.txt | Expose TabbedPage.TabReselected in public API for each TF |
Comments suppressed due to low confidence (3)
src/Controls/src/Core/TabbedPage/TabbedPage.cs:62
- Missing XML documentation for the
TabReselectedevent; please add a<summary>explaining its purpose.
public event EventHandler TabReselected;
src/Controls/src/Core/TabbedPage/TabbedPage.cs:62
- No tests were added for
TabReselected; please add UI tests in TestCases.HostApp and corresponding NUnit tests in TestCases.Shared.Tests to validate the event is raised.
public event EventHandler TabReselected;
src/Controls/src/Core/Platform/Android/TabbedPageManager.cs:968
- [nitpick] The field
_initialBottomNavigationis a bit ambiguous; consider renaming to_hasInitialNavigationSelectionor_isFirstNavigationTapfor clarity.
bool _initialBottomNavigation;
kubaflo
force-pushed
the
TabbedPage---TabReselected-event
branch
from
c9b235f to
8753ed8
Compare
jsuarezruiz
requested changes
Jul 7, 2025
src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
kubaflo
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
reviewed
Jul 8, 2025
| base.ViewDidLoad(); | ||
| ShouldSelectViewController = (tabController, viewController) => | ||
| { | ||
| if (viewController == tabController.SelectedViewController) |
There was a problem hiding this comment.
Suggested change
| if (viewController == tabController.SelectedViewController) | |
| if (viewController is tabController.SelectedViewController) |
There was a problem hiding this comment.
I m confused this is ShouldSelectViewController and we use that to send an event that we activated?
There was a problem hiding this comment.
Yes, because it always returns true
rmarinho
reviewed
Jul 8, 2025
rmarinho
reviewed
Jul 8, 2025
rmarinho
requested changes
Jul 8, 2025
|
@rmarinho sorry my bad... this PR should be targeted to net10 only Also I've added such comment // The _initialBottomNavigation flag prevents TabActiveTapped from firing during initial setup.
// We only want this event when users actually tap an already-selected tab, not during framework initialization. |
kubaflo
force-pushed
the
TabbedPage---TabReselected-event
branch
from
629fe75 to
2c913e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This proposal introduces a new TabReselected event to the .NET MAUI TabbedPage. This event is raised when a user taps on the currently active tab. It provides developers with a clean and consistent way to handle tab reselection scenarios across platforms.
Motivation
In many tab-based applications, it's a common user expectation that tapping an already selected tab performs an action, such as popping the navigation stack to the root or refreshing the content. Currently, developers must implement workarounds to detect tab reselection, which adds complexity and platform-specific code.
Fixes #27401
Fixes #15301
Fixes #29395