[.Net10][Proposal]Shell - TabActiveTapped event #30446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
proposal/open
platform/android
platform/ios
and removed
community ✨
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new TabReselected event in .NET MAUI Shell to let developers react when the active tab is tapped again. It adds internal plumbing, updates platform handlers, and records the new event in the public API unshipped files.
- Adds
SendTabReselectedmethods inShellSectionandShell - Defines a public
TabReselectedevent inShell - Updates iOS and Android renderers to trigger the new event
- Records the new event in all
PublicAPI.Unshipped.txtfiles
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/src/Core/Shell/ShellSection.cs | Added SendTabReselected to propagate reselection |
| src/Controls/src/Core/Shell/Shell.cs | Declares public TabReselected event and its invoker |
| src/Controls/src/Core/PublicAPI/*/PublicAPI.Unshipped.txt | Records the new public API entry for TabReselected |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs | Triggers SendTabReselected when the selected VC is tapped again |
| src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellItemRenderer.cs | Implements reselection logic with _initialTabNavigation flag |
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellItemRenderer.cs:65
- [nitpick] The field '_initialTabNavigation' is ambiguous; consider renaming it to something like '_hasHandledInitialNavigation' or '_isFirstTabSelection' for clarity.
bool _initialTabNavigation;
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jul 7, 2025
src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Shell/Shell.cs
Outdated
| @@ -1289,7 +1289,7 @@ public ScrollMode FlyoutVerticalScrollMode | |||
|
|
|||
| public event EventHandler<ShellNavigatedEventArgs> Navigated; | |||
| public event EventHandler<ShellNavigatingEventArgs> Navigating; | |||
|
|
|||
| public event EventHandler TabReselected; | |||
There was a problem hiding this comment.
Could add a custom EventArgs with some parameters like the shell section etc
There was a problem hiding this comment.
I can, but what should they include?
kubaflo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This proposal introduces a new TabReselected event for tabs within .NET MAUI Shell. This event is triggered when the user taps on the currently active tab in the bottom tab bar. It provides a consistent and straightforward way for developers to respond to tab reselection scenarios within Shell-based applications.
Motivation
In many modern mobile applications that utilize tab-based navigation, it's a common user expectation that tapping the already active tab performs an action, such as resetting the navigation stack or refreshing the content. Currently, implementing this behavior within .NET MAUI Shell requires manual workarounds and platform-specific logic.
Fixes #27401
Fixes #15301
Fixes #29395