-
Notifications
You must be signed in to change notification settings - Fork 428
Use hardcoded partitions and STS hostnames #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use hardcoded partitions and STS hostnames #876
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gargipanatula The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @gargipanatula. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
} | ||
|
||
AWS_PARTITION_STS_HOSTS = []string{ | ||
"sts.amazonaws.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we shouldn't maintain these hardcoded variables in our repo. because it's hard to automate and refresh the list. how about we instead use the endpoint resolver construct from sdk v2 here?
https://github.com/aws/aws-sdk-go-v2/blob/main/service/sts/endpoints.go#L333
What this PR does / why we need it:
This PR removes calls to the
github.com/aws/aws-sdk-go/aws/endpoints
package by porting over the hardcoded data behind the package into a file within the repository. This is meant to move the repository away from the AWS SDK Go V1, which is set to be deprecated on July 31, 2025.Testing:
Tested the
verify
command to make sure that it continues to authenticate tokens from within a partition, and rejects tokens from across partitions.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #