Skip to content

Use hardcoded partitions and STS hostnames #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gargipanatula
Copy link
Contributor

@gargipanatula gargipanatula commented Jun 27, 2025

What this PR does / why we need it:
This PR removes calls to the github.com/aws/aws-sdk-go/aws/endpoints package by porting over the hardcoded data behind the package into a file within the repository. This is meant to move the repository away from the AWS SDK Go V1, which is set to be deprecated on July 31, 2025.

Testing:
Tested the verify command to make sure that it continues to authenticate tokens from within a partition, and rejects tokens from across partitions.

dev-dsk % /aws-iam-authenticator/_output/bin/aws-iam-authenticator verify --cluster-id=panatula627209 --token=$TOKEN
&{ARN:arn:aws:sts::<id>:assumed-role/<role>/<session> CanonicalARN:arn:aws:iam::<id>:role/<role> AccountID:<id> UserID:<userid> SessionName:<session> AccessKeyID:<key> STSEndpoint:sts.us-west-2.amazonaws.com}

dev-dsk % /aws-iam-authenticator/_output/bin/aws-iam-authenticator verify --cluster-id=panatula627209 --token=$TOKEN --partition=aws-cn
could not verify token: input token was not properly formatted: unexpected hostname "sts.us-west-2.amazonaws.com" in pre-signed URL

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gargipanatula
Once this PR has been reviewed and has the lgtm label, please assign kmala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from yue9944882 June 27, 2025 20:50
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @gargipanatula. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 27, 2025
@kmala
Copy link
Contributor

kmala commented Jun 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2025
}

AWS_PARTITION_STS_HOSTS = []string{
"sts.amazonaws.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we shouldn't maintain these hardcoded variables in our repo. because it's hard to automate and refresh the list. how about we instead use the endpoint resolver construct from sdk v2 here?

https://github.com/aws/aws-sdk-go-v2/blob/main/service/sts/endpoints.go#L333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants