Closed
Description
What happened:
The comments for SubdomainShared and SubdomainUniquePerReplica in the CRD are misleading.
They incorrectly describe the Service and hostname behavior under each SubdomainPolicy.
For example, the current comment says in Shared mode, replica 0 will have a hostname like my-lws-0.my-lws, suggesting there are multiple Services involved, which is not accurate.
lws/api/leaderworkerset/v1/leaderworkerset_types.go
Lines 234 to 247 in c56aff7
What you expected to happen:
In Shared
mode: there is only one headless Service shared by all replicas, e.g., vllm-pd-lws
.
In UniquePerReplica
mode: there is one Service per replica, e.g., vllm-pd-lws-0
, vllm-pd-lws-1
, etc.
Environment:
- Kubernetes version (use
kubectl version
): - LWS version (use
git describe --tags --dirty --always
): 0.6.2 - Cloud provider or hardware configuration:
- OS (e.g:
cat /etc/os-release
): - Kernel (e.g.
uname -a
): - Install tools:
- Others: