Skip to content

Add KEP#223: Unique Node Selector and Toleration Per Replica #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add KEP#223: Unique Node Selector and Toleration Per Replica #399

wants to merge 5 commits into from

Conversation

Edwinhr716
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it

Adds KEP for #223

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Edwinhr716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2025
@Edwinhr716
Copy link
Contributor Author

@googs1025 Would like your feedback as well if possible since you had already worked on it

@googs1025
Copy link
Member

/cc

I'll be able to give some of my thoughts later this week :)

ahg-g
ahg-g reviewed Mar 14, 2025
View reviewed changes
ahg-g
ahg-g reviewed Mar 14, 2025
View reviewed changes
@netlify Netlify
Copy link

netlify bot commented Mar 17, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-lws canceled.

Name Link
🔨 Latest commit 0333148
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-lws/deploys/67fd41c836ce4c00089d2de8

@kerthcet
Copy link
Contributor

Since we'll release this week and I think the implementation hasn't been ready yet, can we merge this later, I'll take another look. Does that make sense to you?

@Edwinhr716
Copy link
Contributor Author

That makes sense, we can include it in the next release. Not an urgent feature either way

ahg-g
ahg-g reviewed Mar 25, 2025
View reviewed changes
@Edwinhr716
Copy link
Contributor Author

Added ExclusivePlacement to the SchedulingPolicy part of the API. PTAL @ahg-g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@kerthcet kerthcet Awaiting requested review from kerthcet

@googs1025 googs1025 Awaiting requested review from googs1025

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Edwinhr716 @k8s-ci-robot @googs1025 @kerthcet @ahg-g