Update headers after refreshing token during E2E tests #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures updated headers are fetched after every token refresh during E2E tests.
- Removed the loop counter and its conditional check
- Now unconditionally refreshes headers right after refreshing the token
Comments suppressed due to low confidence (1)
e2eTests/e2eTestHelper.psm1:285
- Unconditionally fetching headers on each iteration can degrade test performance; consider limiting calls to when the token actually changes or using a controlled interval.
$headers = GetHeaders -token $ENV:GH_TOKEN -repository $repository
mazhelez
approved these changes
Jun 20, 2025
spetersenms
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❔What, Why & How
Update headers after refreshing token during E2E tests