-
Notifications
You must be signed in to change notification settings - Fork 21
Ardykhalili/adaptivecard kotlin rewrite #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Integrated Kotlin. Serialization - CardElements, ActionElements, Input Elements serialized
Layouts added. knownProperties added.
Added Unit test for all the property
Added Unit test for all the property
# Conflicts: # source/android/adaptivecards/build.gradle # source/android/adaptivecards/src/androidTest/java/io/adaptivecards/objectmodel/TimeInputValidationTest.java # source/android/mobile/src/main/java/io/adaptivecards/adaptivecardssample/MainActivityAdaptiveCardsSample.java
@karthikgopal36 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Description
Implemented native Adaptive Card parsing in Kotlin. This enhancement allows all Card Elements, Action Elements, and Collection Elements to be parsed natively within the Kotlin codebase.
By handling parsing natively, this change is expected to significantly reduce the SDK size and improve runtime performance, especially on resource-constrained devices.
Currently, the new parser is controlled via a boolean flag, enabling us to toggle between the legacy and new parsing implementations. This setup helps in testing and validating the functional and performance differences before fully migrating.
Future iterations may phase out the legacy parser entirely once the new system is fully verified and adopted.
Class Structure
How Verified
Added all the unit test cases, refer EveryThingBagelTests.
Used Visualizer app with the Test cards.