-
Notifications
You must be signed in to change notification settings - Fork 254
Remote vm cicd #4489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LakshK98
wants to merge
7
commits into
microsoft:main
Choose a base branch
from
LakshK98:remote-vm-cicd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remote vm cicd #4489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
reviewed
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for executing CI/CD scripts and deployments on remote VMs by introducing new parameters, branching logic, and documentation.
- Introduces an
IsVMRemote
switch and remote‐execution branches in VM test, setup, and execution scripts. - Extends the deployment script with a
--remote_vm
option to copy files via PowerShell remoting. - Provides a new
remote-vm-setup.md
guide and updatesInstallEbpf.md
to reference remote setup.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
scripts/vm_run_tests.psm1 | Added IsVMRemote param and branch for Invoke-Command -ComputerName |
scripts/setup_ebpf_cicd_tests.ps1 | Added IsVMRemote switch and a remote‐VM setup block |
scripts/execute_ebpf_cicd_tests.ps1 | Passed IsVMRemote into job scriptblock and parameters |
scripts/deploy-ebpf.ps1.in | Added --remote_vm option and WSMan copy logic |
scripts/config_test_vm.psm1 | Extended artifact export, install, and network init to handle remote sessions; added Invoke-CommandOnVM helper |
docs/remote-vm-setup.md | New documentation for configuring and using remote VMs |
docs/InstallEbpf.md | Updated link to include remote VM setup instructions |
Comments suppressed due to low confidence (1)
scripts/vm_run_tests.psm1:8
- New
IsVMRemote
logic branches have been added forInvoke-Command
. Consider adding unit or integration tests to verify both remote and VM invocation paths.
[Parameter(Mandatory = $false)][bool] $IsVMRemote = $false,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for running CI/CD scripts on remote virtual machines (VMs) by adding new parameters and functionality across multiple scripts. Closes #3823
Script Enhancements for Remote VM Support:
Deployment Script Updates:
scripts/deploy-ebpf.ps1.in
to support a--remote_vm
option for specifying remote VM IP address. Added logic for copying files to remote VMs using PowerShell remoting.Setup Script Updates:
scripts/setup_ebpf_cicd_tests.ps1
andscripts/execute_ebpf_cicd_tests.ps1
to support remote VM setup by adding anIsVMRemote
parameter.Testing
Local test runs on nebula vm.
Documentation
Added a remote-vm-setup.md file with instructions on how to setup a remote vm and run scripts on it.
Installation
NA