update extension document and minor changes. #4496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
requested review from
Alan-Jowett,
dthaler,
LakshK98,
matthewige,
mikeagun,
mtfriesen,
poornagmsft and
saxena-anurag
as code owners
dthaler
reviewed
Jul 7, 2025
dthaler
reviewed
Jul 7, 2025
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
dthaler
reviewed
Jul 7, 2025
| "unspec", | ||
| "plain", | ||
| }; | ||
| static const char* const _ebpf_link_display_names[] = {"unspec", "plain", "cgroup", "xdp"}; |
There was a problem hiding this comment.
Question: Is the intent that all third party extensions also have to update this list if needed?
I ask because the "xdp" extension is not in this repo, but apparently requires a change in this repo?
dthaler
approved these changes
Jul 7, 2025
Alan-Jowett
approved these changes
Jul 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
This fixes #3021 . This adds some documentation on the
ebpf_attach_provider_data_t->link_typefield.It also expands the string representations of map type and link type and adds unit tests for that.
Testing
Do any existing tests cover this change? Are new tests needed?
No new tests are needed.
Documentation
Is there any documentation impact for this change?
This is a documentation change.
Installation
Is there any installer impact for this change?
No installation changes.