Skip to content

Expanded Recommendations dataset column #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

flanakin
Copy link
Collaborator

πŸ› οΈ Description

Expanded Recommendations dataset column based on the features/recs branch.

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2025-06 - June milestone Jun 21, 2025
@flanakin flanakin requested review from Copilot and removed request for MSBrett and arthurclares June 21, 2025 11:08
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Jun 21, 2025
@flanakin flanakin requested a review from helderpinto June 21, 2025 11:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Expands the Recommendations dataset schema by adding new resource and recommendation metadata columns, changes numeric types from decimal to real for performance, and updates related documentation.

  • Add ResourceId, ResourceName, ResourceType, SubAccountName, x_RecommendationDescription, x_ResourceGroupName to raw and final ingestion schemas
  • Convert all decimal columns to real in raw tables and v1_2 functions
  • Update upgrade guide, data model, and changelog to reflect schema changes

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/templates/finops-hub/modules/scripts/IngestionSetup_v1_2.kql Extended transformation and final table creation to include new recommendation and resource columns, updated default assignments with coalesce
src/templates/finops-hub/modules/scripts/IngestionSetup_RawTables.kql Updated raw table schema: added new resource/recommendation fields, changed numeric columns from decimal to real
docs-mslearn/toolkit/hubs/upgrade.md Added guidance on replacing decimal with real and listed v1_2 schema changes
docs-mslearn/toolkit/hubs/data-model.md Updated Transactions/Recommendations tables docs to include new columns
docs-mslearn/toolkit/changelog.md Documented additions to Recommendations dataset and performance improvements
Comments suppressed due to low confidence (3)

docs-mslearn/toolkit/hubs/data-model.md:689

  • [nitpick] The table header underline uses 27 hyphens, which may not match the header label lengths and could break markdown rendering. Adjust the hyphen count to align with the column headers for correct formatting.
| --------------------------- | -------- | ------------------------------------ |

docs-mslearn/toolkit/changelog.md:47

  • [nitpick] The nested bullet starts with "- -", which is inconsistent with markdown list syntax and may not render correctly. Use two-space indentation followed by a single hyphen, for example:

    " - Added full support for..."

  - Added full support for FOCUS 1.2 in Azure Data Explorer and Microsoft Fabric across [all managed datasets](hubs/data-model.md#managed-datasets-in-finops-hubs).

src/templates/finops-hub/modules/scripts/IngestionSetup_v1_2.kql:1512

  • This line produces an unnamed boolean and a packed bag without a target column or conditional, which will cause a syntax or runtime error. Wrap the bag_pack in an iif and assign it to a named column, for example:

    RecommendationContext = iif(x_SourceType startswith 'FinOpsHubRecommendations-', bag_pack(...), dynamic({}))

        x_SourceType startswith 'FinOpsHubRecommendations-', bag_pack(

@flanakin flanakin closed this Jun 21, 2025
@flanakin flanakin deleted the flanakin/flanakin/dev/focus-12/hubs-recs12 branch June 21, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants