-
Notifications
You must be signed in to change notification settings - Fork 158
[Hubs] Document remote hubs support and add UI configuration #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
docs-mslearn/toolkit/hubs/deploy.md
Outdated
@@ -89,6 +89,82 @@ Public routing doesn't require configuration. If you opt for private routing, wo | |||
|
|||
<br> | |||
|
|||
## Optional: Configure remote hubs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this into a separate configure-remote-hubs.md file. Keep a placeholder "Plan for multiple tenants and clouds" section here that links out to the full document. Make sure it calls out that remote hubs can be used for multiple tenants in the same Azure cloud or tenants in different Azure clouds. Supported clouds are:
- Azure Commercial
- Azure Government
- Azure China
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the remote hubs content to a separate configure-remote-hubs.md
file and replaced with a "Plan for multiple tenants and clouds" section that links to the detailed guide. Added explicit support for Azure Commercial, Azure Government, and Azure China as requested. (97867b7)
| **remoteHubStorageUri** | String | Optional. Data Lake storage endpoint from the remote (primary) hub storage account. Used for cross-tenant cost data collection where this hub sends processed data to a central hub. Copy from the primary hub's storage account Settings > Endpoints > Data Lake storage. Example: `https://primaryhub.dfs.core.windows.net/` | | | ||
| **remoteHubStorageKey** | String | Optional. Storage account access key for the remote (primary) hub. Used with remoteHubStorageUri for cross-tenant scenarios. Copy from the primary hub's storage account Security + networking > Access keys > key1/2 > Key. Must be kept secure as it provides full storage access. | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the "Copy from..." instructions to the Configure remote hubs page. That doesn't need to be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the "Copy from..." instructions from the template.md parameter descriptions. These instructions are now in the Configure remote hubs page. (97867b7)
docs-mslearn/toolkit/hubs/deploy.md
Outdated
|
||
When deploying remote hubs, provide the primary hub's storage details: | ||
|
||
#### [Azure portal](#tab/azure-portal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this down to the deploy the template section as a subbullet under the Azure portal template deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the Azure portal remote hub configuration instructions to the deploy template section as a subbullet under step 14 of the Azure portal deployment. (97867b7)
[-RemoteHubStorageUri <string>] ` | ||
[-RemoteHubStorageKey <string>] ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure these changes are applied to the Deploy-FinOpsHub.ps1 PowerShell command and that there's also a unit test to verify the parameters are set correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the Deploy-FinOpsHub.ps1 PowerShell command already includes the remote hub parameters correctly and added comprehensive unit tests to verify the parameters are set correctly for individual and combined remote hub scenarios. (97867b7)
… docs Co-authored-by: flanakin <399533+flanakin@users.noreply.github.com>
This PR implements comprehensive documentation and UI support for remote hubs (cross-tenant) functionality in FinOps hubs.
Problem
Remote hubs support was added to the backend infrastructure but was never fully documented or accessible through the UI deployment form. Users had no guidance on how to configure cross-tenant scenarios where satellite hubs send data to a central primary hub.
Solution
1. UI Form Enhancement
createUiDefinition.json
remoteHubStorageUri
field with Data Lake storage URI validationremoteHubStorageKey
field as secure password input with storage key validation2. Comprehensive Documentation
3. PowerShell Documentation Updates
Deploy-FinOpsHub
command syntax to include remote hub parameters4. Enhanced Template Documentation
remoteHubStorageUri
andremoteHubStorageKey
Key Features
Configuration Parameters
remoteHubStorageUri
: Data Lake storage endpoint from primary hub (e.g.,https://primaryhub.dfs.core.windows.net/
)remoteHubStorageKey
: Storage account access key from primary hubUsage Example
The backend implementation already existed - this PR completes the user-facing documentation and UI integration to make remote hubs fully accessible and properly documented.
Fixes #1093.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.