feat(react-calendar-compat): added reverse Date selection #34468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
🤖 This report was generated against 2ae40918b8d18d85c19fd1414154283d1e9e9b82 |
|
Pull request demo site: URL |
ValentinaKozlova
force-pushed
the
feat/date-picker-selection-date-range
branch
from
c7fc86b to
f3b3278
Compare
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-react-components/Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Avatar Converged.badgeMask.normal.chromium.png | 4 | Changed |
vr-tests-react-components/Positioning 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png | 611 | Changed |
| vr-tests-react-components/Positioning.Positioning end.chromium.png | 749 | Changed |
vr-tests-react-components/Skeleton converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with circle - High Contrast.default.chromium.png | 1 | Changed |
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with rectangle - Dark Mode.default.chromium.png | 29 | Changed |
| vr-tests-react-components/Skeleton converged.Opaque Skeleton with rectangle.default.chromium.png | 15 | Changed |
vr-tests-react-components/TagPicker 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-react-components/TagPicker.disabled - High Contrast.chromium.png | 1321 | Changed |
There were 1 duplicate changes discarded. Check the build logs for more information.
ValentinaKozlova
force-pushed
the
feat/date-picker-selection-date-range
branch
from
f3b3278 to
9fa5e02
Compare
ValentinaKozlova
force-pushed
the
feat/date-picker-selection-date-range
branch
from
9fa5e02 to
b5750a9
Compare
| @@ -165,6 +165,7 @@ export function getDateRangeArray( | |||
| firstDayOfWeek: DayOfWeek, | |||
| workWeekDays?: DayOfWeek[], | |||
| daysToSelectInDayView: number = 1, | |||
| reverse?: boolean, | |||
There was a problem hiding this comment.
I don't like the idea of adding another parameter to this function as it's already pretty complex. Maybe it would be good to split it to get rid of so many parameters. But currently I did it according to existing style
|
Closing this PR as there's a better approach: #34541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reverse Date selection.
Previous Behavior
Selection was possible only in one direction
New Behavior
Added
reverseparam for negative date range selectionRelated Issue(s)
#28961