-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(a11y): remove deprecated css properties #34550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(a11y): remove deprecated css properties #34550
Conversation
189919b
to
b1d47f7
Compare
📊 Bundle size reportUnchanged fixtures
|
Pull request demo site: URL |
1ce6bc6
to
d49e7c9
Compare
this seems like breaking change which will affect every user of v8. can you please double check @dzearing @AtishayMsft ? ty |
Changes are good from charting team side. In our testing, we’ve never seen it match in any browser. Usually, only the latter part of high contrast media queries - separated by , ("or") - gets matched. And they also have good browser compatibility overall. CC @krkshitij |
16fdb7d
to
19ba049
Compare
For more context: this change is applied to fix an a11y issue filed by the Trusted Tester team which marked the We'll probably have to do more refactoring. cc @micahgodbolt |
🕵 . No visual changes in this PR |
This pull request updates the high-contrast media query selectors in
CommonStyles.ts
to remove legacy support for the-ms-high-contrast
feature, which is specific to older versions of Microsoft browsers.These selectors are showing up on the v8 docsite and they were flagged by our a11y team.
Updates to high-contrast media queries:
HighContrastSelector
: Removed the-ms-high-contrast: active
condition, keeping onlyforced-colors: active
for modern browser compatibility.HighContrastSelectorWhite
andHighContrastSelectorBlack
: Updated to remove-ms-high-contrast
conditions and retain onlyforced-colors: active
with appropriateprefers-color-scheme
conditions.EdgeChromiumHighContrastSelector
: Deprecated and simplified by removing the-ms-high-contrast: active
condition, leaving onlyforced-colors: active
.