-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(react-charts): Add support for secondary y axis in cartesian charts #34665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-charts): Add support for secondary y axis in cartesian charts #34665
Conversation
...s/charts/react-charts/library/src/components/AreaChart/__snapshots__/AreaChart.test.tsx.snap
Outdated
Show resolved
Hide resolved
packages/charts/react-charts/library/src/utilities/utilities.ts
Outdated
Show resolved
Hide resolved
Can you resolve merge conflict so we can see the PR storybook |
The findVSBCNumericMinMaxOfY function also needs to be updated: fluentui/packages/charts/react-charts/library/src/utilities/utilities.ts Lines 1572 to 1577 in c196e4c
For reference: Lines 1419 to 1438 in c196e4c
|
…sr/agupta/portv8Fixes
📊 Bundle size report✅ No changes found |
Pull request demo site: URL |
...charts/stories/src/VerticalStackedBarChart/VerticalStackedBarChartSecondaryYAxis.stories.tsx
Show resolved
Hide resolved
Could you run and validate playwright report. |
Yes, ran the report. |
...arts/react-charts/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* master: (51 commits) release: applying package updates - react v8 fix(react-charting): Improve legend selection for Scatter charts (microsoft#34701) release: applying package updates - web-components [fix]: vertical tablist and start and end slots in tabs were broken (microsoft#34704) feat: shorten pollDuration to 100ms (microsoft#34703) fix(web-components): add dropdown anchor positioning fallback (microsoft#34647) React-Carousel: Call emblaApi destroy on unmount (microsoft#34686) release: applying package updates - react-components feat: improve useSafeZoneArea() hook (microsoft#34677) release: applying package updates - react v8 feat(react-charts): Add support for negative Y values in GVBC (microsoft#34687) feat(react-charting): enable wrapping of string x-axis labels in DeclarativeChart + hide overlapping labels based on post-transform width (microsoft#34666) feat(react-charts): Add support for negative VSBC (microsoft#34668) fix(react-charting): correct bar height rendering for values less than 1 in VSBC (microsoft#34680) feat(react-charts): Add support for secondary y axis in cartesian charts (microsoft#34665) release: applying package updates - web-components fix: progress bar when value is missing in firefox and safari (microsoft#34684) release: applying package updates - react v8 release: applying package updates - web-components refactor: use css attr func to calculate progress bar width when supp… (microsoft#34674) ...
New Behavior
Support for secondary y axis is added in cartesian charts.
Corresponding v8 commit migrated to v9:
d5a6890
Related Issue(s)