fix(react-table): add support for native table elements #34817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
ling1726
reviewed
Jul 10, 2025
| @@ -2,7 +2,7 @@ import type { ComponentProps, ComponentState, Slot } from '@fluentui/react-utili | |||
| import { TableContextValue } from '../Table/Table.types'; | |||
|
|
|||
| export type TableCellSlots = { | |||
| root: Slot<'td', 'div'>; | |||
| root: Slot<'td', 'th' | 'div'>; | |||
There was a problem hiding this comment.
Suggested change
| root: Slot<'td', 'th' | 'div'>; | |
| root: Slot<'td', 'div'>; |
This shouldn't be necessary - there is TableHeaderCell for that
There was a problem hiding this comment.
The reason for this change is that the DataGridSelectionCell rendered in the header uses the TableCell (and not TableHeaderCell). Is there another way to implement that?
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the given code example:
Previous Behavior
DataGrid components accepted
as="table"(also sub elements oftable), but were not rendering them, leading to incorrect markupNew Behavior
DataGrid now renders correct table elements.