Collect log using SerialConsole when SshShell fails to connect #3845
+208
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssh may not succeed due to many reasons, at present if ssh fails it is either very difficult or impossible to triage the issue without reproducing it. This change uses SerialConsole to run commands for log collection.
|
@squirrelsc @LiliDeng , this PR is for early design review. This will enhance triaging of failures for both engineers and AI |
squirrelsc
reviewed
Jun 5, 2025
squirrelsc
reviewed
Jun 5, 2025
squirrelsc
reviewed
Jun 9, 2025
squirrelsc
reviewed
Jun 9, 2025
kamalca
reviewed
Jun 18, 2025
|
|
||
| # Prepare the RunCommandInput for Azure | ||
| command = RunCommandInput( | ||
| command_id="RunShellScript", |
There was a problem hiding this comment.
Is this Linux specific? Consider whether you can add support for Windows. If not possible, think about how to exclude the Feature for non-Posix systems.
adityagesh
force-pushed
the
aditya/serial_log_after_test_failure
branch
from
5a994dd to
ff40ee5
Compare
adityagesh
force-pushed
the
aditya/serial_log_after_test_failure
branch
from
ff40ee5 to
bc92811
Compare
adityagesh
commented
Jul 7, 2025
adityagesh
force-pushed
the
aditya/serial_log_after_test_failure
branch
from
df59804 to
a69b551
Compare
Introduce NonSshExecutor. It Internally uses SerialConsole/RunCommand
adityagesh
force-pushed
the
aditya/serial_log_after_test_failure
branch
from
a69b551 to
84d4f4a
Compare
squirrelsc
reviewed
Jul 8, 2025
| :return: A string containing the output of the executed commands. | ||
| """ | ||
| out = [] | ||
| serial_console = self._node.features[SerialConsole] |
There was a problem hiding this comment.
Check if the feature is not available, raise an exception.
squirrelsc
reviewed
Jul 8, 2025
| self.log.debug( | ||
| f"Failed to collect logs using non-ssh executor: {log_error}" | ||
| ) | ||
| raise e |
squirrelsc
reviewed
Jul 8, 2025
| if self.features.is_supported(NonSshExecutor): | ||
| non_ssh_executor = self.features[NonSshExecutor] | ||
| out = non_ssh_executor.execute() | ||
| return "\n".join(out) |
There was a problem hiding this comment.
Log could be output in this method directly, instead of return and output in upper level.
squirrelsc
reviewed
Jul 8, 2025
| execution method for scenarios where SSH connectivity is not possible or desired. | ||
| """ | ||
|
|
||
| COMMANDS_TO_EXECUTE = [ |
There was a problem hiding this comment.
The commands are not related to NonSshExecutor, they should be moved to node level.
squirrelsc
reviewed
Jul 8, 2025
| password = self._connection_info.password | ||
| if not password: | ||
| raise RequireUserPasswordException( | ||
| "The password is not set, and generate is False." |
There was a problem hiding this comment.
The password has not been set and generated.
squirrelsc
reviewed
Jul 8, 2025
squirrelsc
reviewed
Jul 9, 2025
| @@ -190,6 +191,34 @@ def check_initramfs( | |||
| f"{initramfs_logs} {filesystem_exception_logs}" | |||
| ) | |||
|
|
|||
| def login(self) -> None: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssh may not succeed due to multiple reasons, at present if ssh fails it is either very difficult or impossible to triage the issue without reproducing it.
This change uses NonSshExecutor to run commands for log collection.