mshv: add a testcase for mshvtrace #3909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
praveen-pk
commented
Jul 3, 2025
praveen-pk
commented
- Add a testcase for mshvtrace
- fix logfile size detection for mshvlog
squirrelsc
reviewed
Jul 3, 2025
LiliDeng
reviewed
Jul 4, 2025
LiliDeng
reviewed
Jul 4, 2025
praveen-pk
force-pushed
the
mshvtrace
branch
3 times, most recently
from
ba7fb95 to
2d48369
Compare
pupacha
previously approved these changes
Jul 9, 2025
squirrelsc
reviewed
Jul 9, 2025
praveen-pk
force-pushed
the
mshvtrace
branch
2 times, most recently
from
256943d to
40a5411
Compare
pupacha
previously approved these changes
Jul 9, 2025
fix the file path for mshvlog's log file. Check for non-zero logfile size for 10 seconds. The mshvlog_logfile is of the node and not local machine. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com> Co-authored-by: Purna Pavan Chandra Aekkaladevi <paekkaladevi@microsoft.com> mshv: fix: Check the file size in the node The mshvlog_logfile is of the node and not local machine. Fixes: microsoft#3869
This testcase runs mshvtrace and checks the size of the output file. Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
|
@LiliDeng LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.