New test cases added for performance validation of resource disks #3910
Conversation
Update storageperf.py Exclude all azure data disks addition
|
@SRIKKANTH Do you know whether we guarantee the performance of resource disks? |
lisa/features/disks.py
Outdated
| @@ -74,10 +74,11 @@ def get_resource_disk_mount_point(self) -> str: | |||
| raise NotImplementedError | |||
|
|
|||
| def get_resource_disks(self) -> List[str]: | |||
| return [] | |||
| raise NotImplementedError | |||
There was a problem hiding this comment.
Why change this? The resource disk is cloud specific feature, so it should return empty by default.
|
|
||
| def get_resource_disk_type(self) -> schema.ResourceDiskType: | ||
| return schema.ResourceDiskType.SCSI | ||
| controller_type = self.get_os_disk_controller_type() |
There was a problem hiding this comment.
The method is called get_resource_disk_type, but it calls get_os_disk.... It's inconsistent between name and logic.
| @@ -153,10 +153,9 @@ def _remove_nvme_os_disk(self, disk_list: List[str]) -> List[str]: | |||
| ): | |||
| os_disk_nvme_device = self._get_os_disk_nvme_device() | |||
| # Removing OS disk/device from the list. | |||
| for disk in disk_list: | |||
| for disk in disk_list.copy(): | |||
There was a problem hiding this comment.
The original logic is to remove one, the new logic is to remove all. Is there any reason to change it?
There was a problem hiding this comment.
This is for OS disk along with all remote data disk.
There was a problem hiding this comment.
Earlier logic only excludes only OS disk we need to exclude all remote disks not just OS disk. If same VM used for both premium 4k perf and resource disk perf/ nvme perf all remove disks also considered NVMe devices. Thats the reason we need to exclude all remote disks.
We do. You can check the numbers under local disk. Recent MPF is giving higher IOPS so we should make sure perf is upto spec. |
Added new test cases for performance validation of resource disks.
Testcases added:
These testcases support both SCSI and NVMe local/resource disks.