Skip to content

Remove view/conversions.h overrides #14698

Open
@TatianaKapos

Description

@TatianaKapos

Problem Description

Upstream recently edited ‎packages/react-native/ReactCommon/react/renderer/components/view/conversions.h which incorrectly casts an double to a float. Added a one-line fix to static_cast to a float

Added code:
return static_cast<float>(std::get<CSSAngle>(angle).degrees * M_PI / 180.0f); // [Windows]

This should be an easy PR to make upstream.

Link to the integration where the error originated

#14693

Link to commit

facebook/react-native@c99b717

Forked files

1.vnext/ReactCommon/TEMP_UntilReactCommonUpdate/react/renderer/components/view/conversions.h

Upstream PR

N/A

Build Configuration

None

Metadata

Metadata

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions