Open
Description
Problem Description
Upstream added the following methods to their RuntimeAgent (see linked commits) and our HermesRuntimeHolder would need to implement these methods.
- enableSamplingProfiler
- disableSamplingProfiler
- collectSamplingProfile
Currently stubbed these methods out but unsure if we need a proper implementation
Link to the integration where the error originated
Link to commit
https://github.com/facebook/react-native/pull/48836/files
https://github.com/facebook/react-native/pull/48315/files
Forked files
Stub Methods in
- vnext/Shared/HermesRuntimeHolder.cpp
- vnext/Shared/HermesRuntimeHolder.h
- TEMP_UntilReactCommonUpdate/cxxreact/JSExecutor.cpp
- ReactCommon/TEMP_UntilReactCommonUpdate/cxxreact/JSExecutor.h
Upstream PR
N/A - we will need to implement in our code
Build Configuration
None