-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[react-native-windows] Use new LongLivedObject.h header namespace #14839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[react-native-windows] Use new LongLivedObject.h header namespace #14839
Conversation
This header moved 2 another package in 2020
@acoates-ms / @vmoroz > Could you take a look at this change? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Hi @christophpurrer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs yarn change
to get the change files to verify it builds, but looks okay to me otherwise.
…icrosoft#14836) * handled ariaHidden for windows with same behaviour as importantForAccessibility and accessibilityElementsHidden as ( android and ios ) * Change files * yarn lint:fix and format * updated e2e tests for aria-hidden scenarios * updated snapshots for new test added for aria-hidden prop * lint fix , wrapped aria-hidden in viewProps * removed js side hacky patch in fabric for handling aria-hidden for children : childrenWithImportantForAccessibility * yarn lint:fix and yarn format * revert e2e tests for aria-hidden prop * Revert "updated snapshots for new test added for aria-hidden prop" This reverts commit c81f273. * updated snapshots for fabric * updated image tests removing aria hidden which caused the test id to be hidden in dump tree
* Changes for updating accessibilityValue prop * Change files
## Description This PR removed the unneeded `@azure/core-auth` dependency from `@react-native-windows/telemetry`. ### Type of Change - Bug fix (non-breaking change which fixes an issue) ### Why To unblock broken CI due to the dependency change made by `@azure` packages. Resolves microsoft#14912 ### What See above. ## Screenshots N/A ## Testing Verified our packages still work ## Changelog Should this change be included in the release notes: _yes_ Removed unneeded `@azure/core-auth` dependency
Thanks @jonthysell > I did not know that. |
Description
This header moved to another package in 2022
Type of Change
Why
We want to delete the header file under the old location
What
No functional change
Screenshots
NA
Testing
CI jobs
Changelog
no_
Microsoft Reviewers: Open in CodeFlow