Window border: Default handling of an invalid color

[bamurtaugh]

Testing #252838

• I tried setting the border to an invalid value and restarted VS Code
• VS Code now defaults to a white border - I expected an invalid border option to default back to the Windows accent color (which in my case, isn't white)

[bamurtaugh]

I also found the border defaults to white if I don't set anything in the setting text box:

It'd be nice if the setting description mentioned using default to get back to using the Windows accent color.

[bpasero]

@deepak1556 can you check the Electron part of this issue where the border is white if invalid, thanks.

[bpasero]

Pushing a fix to:

• mention default in settings description
• using default if setting is empty string

[deepak1556]

@bpasero that would be from https://github.com/electron/electron/blob/07338bb1cf93091a36c047407c0af87438023d25/shell/common/color_util.cc#L43-L45 for empty string value. Would you prefer accent color to be turned off or default to system for empty string ? I feel it should be the latter similar to what happens when it is undefined

[bpasero]

@deepak1556 yeah fallback to default sounds good to me