NES not triggered

[dbaeumer]

Testing #253033

• In the above screen shot I first added a 2 to private nextMessageLength2: number;
• waited. Nothing happened.
• move the cursor to line 187. Still nothing happens
• triggering NES per command suggests adding a 2 to the next line

You see two new requests in the Log view:

[dbaeumer]

Line 187 is this._partialMessageTimeout = 10000;

[dbaeumer]

log.txt.txt

[dbaeumer]

I also see a new XtabProvider request eveytime I trigger NES manually in this scenario.

[vs-code-engineering]

Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.

[chrmarti]

The fix is to reduce the text range for the cursor position for which we will return a cache entry with the 'no edit' result.

To verify:

• Create a TypeScript file with:

class Point {
	x: number;
	y: number;
	constructor(x: number, y: number) {
		this.x = x;
		this.y = y;
	}
	dist() {
		return Math.sqrt(this.x ** 2 + this.y ** 2);
	}
}
const x = new Point(1, 2);
const y = new Point(3, 4);

• Open the Chat output channel and filter for [NES][Triggerer] to catch unrelated reasons for not running a NES request.
• Open the Copilot Chat Debug panel to see request from core (NES) and LLM requests (XtabProvider).
• Do the following without waiting much in between. (We don't run LLM requests on cursor movement when there was no recent document change.)
• Append X to Point making it PointX.
• Move cursor to 6 lines above the first reference to Point. (The this.y = y; line. The edit window includes only 5 lines below the cursor position.)
• Expect: No NES suggestion.
• Move the cursor down line by line.
• Expect: No NES suggestion until 2 lines above the const x = new Point(1, 2); line. There you should get a suggestion to update the two Point references.